release-notes: Add custom regex option#4272
Open
damemi wants to merge 1 commit intokubernetes:masterfrom
Open
Conversation
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
damemi
force-pushed
the
release-notes-custom-regex
branch
from
e473b7c to
1e0d5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an option to define a custom release-note block for the release-notes tool
This tool is great and easily adapted to our own project outside of k8s. We would just like to have a stricter regex than the 4 existing defaults. We saw that just blank code blocks in PR descriptions were also matching as release notes.
Understandable if this isn't meant to be used outside of kubernetes, but I figured this change could be useful in the future here too.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?